Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tfsec (v1.28.0) on all platforms #359

Closed
wants to merge 4 commits into from

Conversation

Kevin-CB
Copy link
Contributor

For #198

This PR add tfsec on all platforms

Not sure if I had to add an yml file on the updatecli

@dduportal dduportal changed the title feat: add tfsec on all platforms feat: add tfsec (v1.28.0) on all platforms Oct 14, 2022
@dduportal
Copy link
Contributor

  • Just triggered a build (as your code looks good to me!). Let's see if it works as expected (I'm not sure for linux-arm64)

Not sure if I had to add an yml file on the updatecli

Usually, we do a subsequent PR (separation of concerns) . Don't worry on this.

Oops, this empty file have nothing to do here
@dduportal dduportal mentioned this pull request Oct 14, 2022
@lemeurherve lemeurherve linked an issue Oct 14, 2022 that may be closed by this pull request
@dduportal
Copy link
Contributor

The Windows builds are failing because tfsec 1.28.0 does not exist on chocolatey: https://community.chocolatey.org/packages?q=tfsec (only 1.22.1 as for today :'( ).

Could you either:

@lemeurherve
Copy link
Member

Or we wait a little for aquasecurity/tfsec-chocolatey#8 🙂

@dduportal
Copy link
Contributor

Given the time it takes to the chocolatey maintainer to update this recipe (and it seems to be the same for most of the chocolatey packages such as git, vagrant, packer, etc.), I feel like we should go with the binary installation instead. WDYT @lemeurherve @Kevin-CB ?

@Kevin-CB
Copy link
Contributor Author

Kevin-CB commented Nov 7, 2022

Yeah you're right, I'll work on that when time permits 🙂

@dduportal
Copy link
Contributor

Gentle ping 🧸

@Kevin-CB Kevin-CB closed this Jan 8, 2023
@Kevin-CB Kevin-CB deleted the feat/tfsec branch January 8, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tfsec to images
3 participants