-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python3 version to 3.13.1 #1620
Merged
dduportal
merged 3 commits into
main
from
updatecli_main_2069c037197af68ddd6a68a8065530ff3a4c40696f8f57f39cd43a0d3472bd10
Jan 2, 2025
Merged
Bump python3 version to 3.13.1 #1620
dduportal
merged 3 commits into
main
from
updatecli_main_2069c037197af68ddd6a68a8065530ff3a4c40696f8f57f39cd43a0d3472bd10
Jan 2, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins-infra-updatecli
bot
force-pushed
the
updatecli_main_2069c037197af68ddd6a68a8065530ff3a4c40696f8f57f39cd43a0d3472bd10
branch
3 times, most recently
from
January 2, 2025 08:19
6a92ab8
to
7c82731
Compare
dduportal
approved these changes
Jan 2, 2025
dduportal
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails on Windows: c:\python312\python.exe
(because c:\python313\python.exe
is expected...) Updatecli change required?
jenkins-infra-updatecli
bot
force-pushed
the
updatecli_main_2069c037197af68ddd6a68a8065530ff3a4c40696f8f57f39cd43a0d3472bd10
branch
from
January 2, 2025 09:33
3b3adbe
to
f494332
Compare
dduportal
approved these changes
Jan 2, 2025
dduportal
approved these changes
Jan 2, 2025
Note: fixed the Windows provisioning script with 285c876: commit 285c876d294e7e1c7e4f3112ff070c48616cb352
Author: Damien Duportal <[email protected]>
Date: Thu Jan 2 14:59:20 2025 +0100
hotfix(windows) compute Python installation dir from its version
Signed-off-by: Damien Duportal <[email protected]>
diff --git a/provisioning/windows-provision.ps1 b/provisioning/windows-provision.ps1
index 6a1b1e7..e5ae712 100644
--- a/provisioning/windows-provision.ps1
+++ b/provisioning/windows-provision.ps1
@@ -83,6 +83,9 @@ New-Item -ItemType Directory -Path $baseDir -Force | Out-Null
$dockerPluginsDir = 'C:\ProgramData\docker\cli-plugins'
New-Item -ItemType Directory -Path $dockerPluginsDir -Force | Out-Null
+# Compute the future python installation dir
+$pythondir = 'C:\python{0}' -f "${env:PYTHON3_VERSION}".Replace(".", "")
+
# Ensure NuGet package provider is initialized (non-interactively)
Get-PackageProvider NuGet -ForceBootstrap
@@ -258,7 +261,7 @@ $downloads = [ordered]@{
& Remove-Item -Force -Recurse "$baseDir\chocolatey.tmp";
};
'cleanupLocal' = 'true';
- 'path' = "C:\HashiCorp\Vagrant\;C:\Program Files\Amazon\AWSCLIV2\;c:\python312\;C:\python312\Scripts\;";
+ 'path' = "C:\HashiCorp\Vagrant\;C:\Program Files\Amazon\AWSCLIV2\;${pythondir}\;${pythondir}\Scripts\;";
'postInstall' = {
# Installation of make for Windows
& "choco.exe" install make --yes --no-progress --limit-output --fail-on-error-output;
@@ -280,8 +283,8 @@ $downloads = [ordered]@{
# Installation of python3 for Launchable
& "choco.exe" install python3 --yes --no-progress --limit-output --fail-on-error-output --version "${env:PYTHON3_VERSION}";
# Installation of Launchable globally (no other python tool)
- & "c:\python312\python.exe" -m pip --no-cache-dir --upgrade install setuptools wheel pip;
- & "c:\python312\python.exe" -m pip --no-cache-dir install launchable=="${env:LAUNCHABLE_VERSION}";
+ & "${pythondir}\python.exe" -m pip --no-cache-dir --upgrade install setuptools wheel pip;
+ & "${pythondir}\python.exe" -m pip --no-cache-dir install launchable=="${env:LAUNCHABLE_VERSION}";
};
};
} |
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Signed-off-by: Damien Duportal <[email protected]>
jenkins-infra-updatecli
bot
force-pushed
the
updatecli_main_2069c037197af68ddd6a68a8065530ff3a4c40696f8f57f39cd43a0d3472bd10
branch
from
January 2, 2025 14:59
285c876
to
5b37d47
Compare
dduportal
force-pushed
the
updatecli_main_2069c037197af68ddd6a68a8065530ff3a4c40696f8f57f39cd43a0d3472bd10
branch
from
January 2, 2025 15:00
972e353
to
0f9f9b2
Compare
dduportal
deleted the
updatecli_main_2069c037197af68ddd6a68a8065530ff3a4c40696f8f57f39cd43a0d3472bd10
branch
January 2, 2025 17:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump python3 version
Update the python3 version in the tools-versions.yml file
change detected: * key "$.python3_version" updated from "3.12.6" to "3.13.1", in file "provisioning/tools-versions.yml"
Update the `python3` version in the goss test
change detected: * key "$.command.python3.stdout[0]" updated from "3.12.6" to "3.13.1", in file "tests/goss-windows.yaml"
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!