feat(Jenkinsfile_gc) adds cron trigger expression #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayfranco999 <[email protected]>
dduportal
requested changes
Nov 18, 2024
There was a problem hiding this comment.
- This PR has not been tested: it fails with the following error:
08:56:07 WorkflowScript: 6: Unknown stage section "triggers". Starting with version 0.5, steps in a stage must be in a ‘steps’ block. @ line 6, column 9.
08:56:07 stage('Garbage Collection') {
=> when changing a pipeline in a PR, start in Draft, validate your change and then turn the PR ready to review once you're sure it is at least parseable (or test the pipeline locally on a custom Jenkins container)
- We want to have the job running once an hour (we never discussed the frequency no worries) instead of once a day ideally. Could you update the PR according to this request?
=> Note as per https://www.jenkins.io/doc/book/pipeline/syntax/#cron-syntax
In addition,
@yearly,@annually,@monthly,@weekly,@daily,@midnight, and@hourlyare supported as convenient aliases.
Signed-off-by: jayfranco999 <[email protected]>
jayfranco999
force-pushed
the
gc-cron-trigger
branch
from
9b5212e to
f813472
Compare
dduportal
reviewed
Nov 18, 2024
Co-authored-by: Damien Duportal <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
dduportal
approved these changes
Nov 18, 2024
3 tasks
jayfranco999
added a commit
to jayfranco999/packer-images
that referenced
this pull request
Nov 26, 2024
* feat Signed-off-by: jayfranco999 <[email protected]> * fixup Signed-off-by: jayfranco999 <[email protected]> * Update Jenkinsfile_gc Co-authored-by: Damien Duportal <[email protected]> * fixup Signed-off-by: jayfranco999 <[email protected]> --------- Signed-off-by: jayfranco999 <[email protected]> Co-authored-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#4355 (comment)
As per #1526 (review)
We add cron trigger expression to the pipeline to execute only once daily.