feat!(packer-images):Adding all Amazon builder logic for EC2 instances #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayfranco999
commented
Oct 2, 2024
jayfranco999
commented
Oct 2, 2024
jayfranco999
commented
Oct 2, 2024
jayfranco999
commented
Oct 2, 2024
jayfranco999
commented
Oct 2, 2024
jayfranco999
force-pushed
the
ec2-templates
branch
from
3400012 to
83dcbf7
Compare
jayfranco999
changed the title
smerle33
reviewed
Oct 7, 2024
jayfranco999
commented
Oct 7, 2024
smerle33
reviewed
Oct 7, 2024
sources.pkr.hcl
Outdated
| @@ -7,7 +7,7 @@ source "amazon-ebs" "base" { | |||
| secret_key = var.aws_secret_access_key | |||
|
|
|||
| ami_name = "${local.image_name}-${var.architecture}-${local.now_unix_timestamp}" | |||
| instance_type = local.aws_spot_instance_types[var.architecture] | |||
| instance_type = [local.aws_spot_instance_types[var.architecture][0]] | |||
There was a problem hiding this comment.
smerle33
reviewed
Oct 7, 2024
sources.pkr.hcl
Outdated
|
|
||
| ami_name = "${local.image_name}-${var.architecture}-${local.now_unix_timestamp}" | ||
| # instance_type = local.aws_spot_instance_types[var.architecture] | ||
| instance_type = "t2.xlarge" |
There was a problem hiding this comment.
to show you that it work with one instance name
jayfranco999
force-pushed
the
ec2-templates
branch
from
dbed9ac to
f5cdb30
Compare
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Co-authored-by: Stéphane MERLE <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
jayfranco999
force-pushed
the
ec2-templates
branch
from
f5cdb30 to
7926bdb
Compare
Signed-off-by: jayfranco999 <[email protected]>
jayfranco999
commented
Oct 14, 2024
Comment on lines
+20
to
+27
| variable "aws_access_key_id" { | ||
| type = string | ||
| default = env("AWS_ACCESS_KEY_ID") | ||
| } | ||
| variable "aws_secret_access_key" { | ||
| type = string | ||
| default = env("AWS_SECRET_ACCESS_KEY") | ||
| } |
There was a problem hiding this comment.
Need to remove, first let's read the amazon builder provider documentation.
https://developer.hashicorp.com/packer/integrations/hashicorp/amazon#environment-variables
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: jenkins-infra/helpdesk#4316
draft PR (DO NOT MERGE)!!