feat(cijenkinsio-agents-2) adding the jenkins agents for bom and others builds #6026
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Ref. jenkins-infra/helpdesk#4460
=> needs to remove any reference to the "registry secrets" chart
Comment on lines
+15
to
+24
| - name: docker-registry-secrets | ||
| # This helm chart doesn't create any resources within the namespace specified below. | ||
| # Specifying a namespace is required by the "needs" feature of helmfile (to allow referencing to this release from others) | ||
| namespace: default | ||
| chart: jenkins-infra/docker-registry-secrets | ||
| version: 0.1.0 | ||
| values: | ||
| - "../config/docker-registry-secrets.yaml" | ||
| secrets: | ||
| - "../secrets/config/docker-registry-secrets/secrets.yaml" |
There was a problem hiding this comment.
Suggested change
| - name: docker-registry-secrets | |
| # This helm chart doesn't create any resources within the namespace specified below. | |
| # Specifying a namespace is required by the "needs" feature of helmfile (to allow referencing to this release from others) | |
| namespace: default | |
| chart: jenkins-infra/docker-registry-secrets | |
| version: 0.1.0 | |
| values: | |
| - "../config/docker-registry-secrets.yaml" | |
| secrets: | |
| - "../secrets/config/docker-registry-secrets/secrets.yaml" |
Comment on lines
+26
to
+27
| needs: | ||
| - default/docker-registry-secrets |
There was a problem hiding this comment.
Suggested change
| needs: | |
| - default/docker-registry-secrets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/helpdesk#4319 (comment)
and following #6020
this PR add the jenkins-kubernetes-agents releases with service-account, rbac, ressources-quotas, dockerhub-registry-secrets as per https://github.com/jenkins-infra/helm-charts/blob/main/charts/jenkins-kubernetes-agents/