chore(infra-jobs): remove githubCheckNames

[lemeurherve]

This PR removes the GitHub check names, now useless since the use of https://github.com/jenkinsci/github-scm-trait-notification-context-plugin:

Ref:

• Updatecli: Use separated pipelines + organization scanning for all updatecli processes in jenkins-infra helpdesk#2778 (comment)

[timja]

FWIW those status checks names are incredible long =/

[lemeurherve]

FWIW those status checks names are incredible long =/

I'd suggest removing:

• "jenkins" prefix:
  • Does not add meaningful information
  • Implied by the instance name coming just after
• The job name:
  • There isn't any case where two jobs are running in the same folder AFAIK
  • It's duplicated between jobs running on the same instance
  • It can easily be determined from:
    • the current repo
    • hover on link
• And maybe the "pr-merge/branch" suffix:
  • Always "pr-merge" on PR
  • Always "branch" otherwise
    (AFAIK)

From:

jenkins/infra.ci.jenkins.io/kubernetes-jobs/kubernetes-management/pr-merge
jenkins/infra.ci.jenkins.io/updatecli/kubernetes-management/pr-merge

To:

infra.ci.jenkins.io/kubernetes-jobs/pr-merge
infra.ci.jenkins.io/updatecli/pr-merge

Or even:

infra.ci.jenkins.io/kubernetes-jobs
infra.ci.jenkins.io/updatecli

Answering the two important questions about status checks:

• Where are they running
• What are their kind

WDYT @timja @dduportal @smerle33?

[timja]

I would think about what is important.

to me that's the check name and it should be first.
There's no need to use / to make it harder to read.

to me its:
kubernetes-management (infra.ci) or even jenkins or build for that folder.

do you even need the jenkins instance for updatecli?
updatecli or updatecli (infra.ci)

it'll be in the actor's name of who creates the check anyway

[lemeurherve]

Agree, the thing is there are some constraints to get it automatically named AFAIU cf @dduportal's explanations at jenkins-infra/helm-charts#1081