Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(account-app): move to arm64 with toleration antiaffinity rules #4343

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Sep 12, 2023

as per jenkins-infra/helpdesk#3619
must wait for jenkins-infra/helm-charts#700 that update the chart that use images compatible with arm64

uses jenkins-infra/helm-charts#702 to ensure arm64 exist before upgrading in production

@smerle33 smerle33 requested a review from dduportal September 12, 2023 12:46
@smerle33 smerle33 marked this pull request as ready for review September 12, 2023 13:16
@smerle33 smerle33 requested a review from a team September 12, 2023 13:16
timja
timja previously approved these changes Sep 12, 2023
@smerle33 smerle33 marked this pull request as draft September 15, 2023 07:08
@smerle33
Copy link
Contributor Author

move in draft as long as the antiaffinity rule is not operating cleanly on azure, trying on wiki : #4334

@smerle33 smerle33 marked this pull request as ready for review September 26, 2023 07:05
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, diff is good.

@smerle33 I let you merge when you are ready

@dduportal
Copy link
Contributor

Taking over from @smerle33 as he is not available, merging (and keeping an eye on deployment right now)

@dduportal dduportal merged commit 1197c2b into jenkins-infra:main Sep 26, 2023
6 checks passed
@smerle33 smerle33 deleted the account-app/antiaffinity/arm64 branch June 18, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants