Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate updatecli stages to their own pipeline #2817

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve marked this pull request as ready for review September 10, 2022 10:36
@lemeurherve lemeurherve requested review from a team and dduportal September 10, 2022 10:36
@lemeurherve lemeurherve changed the title feat: separate updatecli to its own pipeline feat: separate updatecli stages to their own pipeline Sep 10, 2022
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkins-infra/helpdesk#2778 specified a top-level Job of type "GitHub organization scanning" that would search for each Jenkinsfile_updatecli for each branch of each repository.

I understand that you are creating a job alongside the current "kubernetes-management": is there a particular reason for this choice?

note that I'm not against your proposal, neither in favor, it's a neutral question to be sure that I can catch up.

Also, my question is motivated because since we changed from (gh-org job) to (folder of multibranches jobs), there might be a lot of good reasons

@lemeurherve
Copy link
Member Author

Changed to a top level folder job with one children for now.

We'll adapt the jenkins-jobs chart to allow specifying a job of kind: folder with specific jenkinsfilePath, see jenkins-infra/helm-charts#105

@lemeurherve lemeurherve merged commit 597c733 into jenkins-infra:main Sep 12, 2022
@lemeurherve lemeurherve deleted the helpdesk2778-separate-updatecli-pipeline branch September 12, 2022 17:06
lemeurherve added a commit that referenced this pull request Sep 12, 2022
@lemeurherve lemeurherve restored the helpdesk2778-separate-updatecli-pipeline branch September 12, 2022 17:10
lemeurherve added a commit to lemeurherve/kubernetes-management that referenced this pull request Sep 23, 2022
…2817)

* feat: separate updatecli to its own pipeline

Ref: jenkins-infra/helpdesk#2778

* add updatecli job for kubernetes-management on infra.ci

* remove redundant 'Management'

* clean Jenkinsfile_updatecli

* remove unused do token credential for kubernetes-management-updatecli

* update updatecli manifest

* set a top folder with one children instead for now until we adapt the job-dsl chart for a 'organization-scanning' kind

Co-authored-by: Damien Duportal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants