-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn against version range usage #7731
Warn against version range usage #7731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as-is with an optional comment for your consideration.
content/doc/developer/plugin-development/dependency-management.adoc
Outdated
Show resolved
Hide resolved
….adoc Co-authored-by: Mark Waite <[email protected]>
@MarkEWaite I also added in a line regarding dependency updates via dependabot/renovabot. Is that still something that would be approved or should I remove that line prior to any sort of merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a correction of the name
content/doc/developer/plugin-development/dependency-management.adoc
Outdated
Show resolved
Hide resolved
Thanks very much @MarkEWaite, I wasn't sure if it was definitely Renovate or something else |
To address the comment made in this issue I have added an extra line to the Dependency Management documentation to indicate that version range is not something we should encourage.