Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn against version range usage #7731

Conversation

kmartens27
Copy link
Contributor

To address the comment made in this issue I have added an extra line to the Dependency Management documentation to indicate that version range is not something we should encourage.

@kmartens27 kmartens27 requested a review from a team as a code owner December 4, 2024 21:13
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as-is with an optional comment for your consideration.

@kmartens27
Copy link
Contributor Author

@MarkEWaite I also added in a line regarding dependency updates via dependabot/renovabot. Is that still something that would be approved or should I remove that line prior to any sort of merge?

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a correction of the name

@kmartens27
Copy link
Contributor Author

Thanks very much @MarkEWaite, I wasn't sure if it was definitely Renovate or something else

@kmartens27 kmartens27 enabled auto-merge (squash) December 4, 2024 21:24
@kmartens27 kmartens27 merged commit 60ba229 into jenkins-infra:master Dec 4, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants