Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli) fix jenkinscontroller agents images manifests (delete unsued + fix existing #3741

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 22, 2024

Requires jenkins-infra/kubernetes-management#5923 to be deployed to have some AWS credential available.

As explained in #3739 (review), this PR should unblock #3739.

It is a fixup of #3737 which accidentally reintroduced an old updatecli manifest which was tracking all kinds of packer images for our agents but 2 years ago (so not only packer images for AMI and azure, but also non packer images).

This manifest is removed and the AMI tracking has been added for Linux (Ubuntu arm64 and Ubuntu x86).

Closes #3740 which was a result of the (now) removed manifest.

…e unsued + fix existing

Signed-off-by: Damien Duportal <[email protected]>
@dduportal dduportal requested a review from a team as a code owner November 22, 2024 07:59
@dduportal
Copy link
Contributor Author

Local test and checks give the same result: the AMI ID for the 2 Ubuntu will be updated in an automatic PR once merged:

[2024-11-22T08:01:54.384Z] target: target#setUbuntuAgentAMIx86
[2024-11-22T08:01:54.384Z] ---------------------------
[2024-11-22T08:01:54.384Z] 
[2024-11-22T08:01:54.384Z] **Dry Run enabled**
[2024-11-22T08:01:54.384Z] 
[2024-11-22T08:01:54.384Z] ⚠ - change detected:
[2024-11-22T08:01:54.384Z] 	* key "$.profile::jenkinscontroller::jcasc.agent_images.ec2_amis.'ubuntu-22.04-amd64'" should be updated from "\"ami-0bd6642923953e087\"" to "ami-0dab51305a6ce6f30", in file "hieradata/common.yaml"
[2024-11-22T08:01:54.638Z] 
[2024-11-22T08:01:54.638Z] target: target#setUbuntuAgentAMIArm64
[2024-11-22T08:01:54.638Z] -----------------------------
[2024-11-22T08:01:54.638Z] 
[2024-11-22T08:01:54.638Z] **Dry Run enabled**
[2024-11-22T08:01:54.638Z] 
[2024-11-22T08:01:54.638Z] ⚠ - change detected:
[2024-11-22T08:01:54.638Z] 	* key "$.profile::jenkinscontroller::jcasc.agent_images.ec2_amis.'ubuntu-22.04-arm64'" should be updated from "ami-0f126d4f0052d12b6" to "ami-073c491bddb18c1b7", in file "hieradata/common.yaml"
[2024-11-22T08:01:54.892Z] 

@dduportal dduportal merged commit 634db5c into jenkins-infra:production Nov 22, 2024
2 checks passed
@dduportal dduportal deleted the chore/fix-updatecli branch November 22, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant