fix(mirrorbit-lite) only create secrets when needed #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
previously approved these changes
Oct 6, 2023
Signed-off-by: Damien Duportal <[email protected]>
Co-authored-by: Hervé Le Meur <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
dduportal
force-pushed
the
fix/mirrorbits-lite/pvc-secret
branch
from
8b246fa to
3159546
Compare
lemeurherve
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the parent chart for jenkins-infra/helpdesk#2649, caught this tiny bug in the helm chart where secrets where created even if values are not provided.
This PR fixes the bug by adding conditions to create the secrets (and tests).