Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uplink): add PodDisruptionBudget and unittests #821

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Oct 3, 2023

@smerle33 smerle33 requested a review from dduportal October 3, 2023 09:10
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! There is still one issue in the PDB though (see my comment)

charts/uplink/templates/pdb.yaml Show resolved Hide resolved
@dduportal dduportal added enhancement New feature or request uplink labels Oct 3, 2023
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff on prod is good 👏

+ # Source: uplink/templates/pdb.yaml
+ apiVersion: policy/v1
+ kind: PodDisruptionBudget
+ metadata:
+   name: uplink
+   labels:
+     app.kubernetes.io/name: uplink
+     app.kubernetes.io/instance: uplink
+     helm.sh/chart: uplink-0.3.0
+     app.kubernetes.io/version: "1.0"
+     app.kubernetes.io/managed-by: Helm
+ spec:
+   minAvailable: 1
+   selector:
+     matchLabels:
+       app.kubernetes.io/name: uplink
+       app.kubernetes.io/instance: uplink

@dduportal dduportal merged commit 92fc2ad into jenkins-infra:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request uplink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants