feat(reports): add PodDisruptionBudget and unittests #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
Oct 3, 2023
smerle33
force-pushed
the
PDB/reports
branch
2 times, most recently
from
9b8bb2d to
7d59f83
Compare
dduportal
reviewed
Oct 3, 2023
dduportal
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Error when running on production:
Error: Failed to render chart: exit status 1: Error: template: reports/templates/deployment.yaml:56:30: executing "reports/templates/deployment.yaml" at <.Values.resources>: nil pointer evaluating interface {}.resources
see my suggestion (otherwise nice work!)
dduportal
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/helpdesk#3719 (comment)