Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jenkins-jobs) allow disabling git tag discovery #797

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Sep 25, 2023

We see a lot of problems in our updatecli process when run from our Jenkins controller infra.ci.jenkins.io.
The root cause is that the jobs in charge of running updatecli are running a lot of concurent builds at the same time.

This PR allows to disable the tag discovery (and associated buidl strategy) as a step in solving this large scale problem.

Note that I used a double negation because Helm interprets false as emptiness so it's hard to have an easy way without breaking existing.

  • Added unit tests
  • Tried with a diff on production:
    • With no value change: no changes
    • With the proper values updated: LGTM

@dduportal dduportal changed the title feat(jenkins-jobs) allow disabling gittag discovery (and associated b… feat(jenkins-jobs) allow disabling git tag discovery Sep 25, 2023
@dduportal dduportal added enhancement New feature or request jenkins-jobs labels Sep 25, 2023
Copy link
Contributor

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jenkins-jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants