Add optional selective cache refresh option #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboardwell
commented
Sep 25, 2023
| @@ -61,6 +71,10 @@ data: | |||
|
|
|||
| # Default location for cached requests | |||
| location / { | |||
| {{- if .Values.proxy.proxyBypass.enabled -}} | |||
| add_header Cache $upstream_cache_status; | |||
There was a problem hiding this comment.
The Cache header is, of course, optional but I like the transparency it provides.
|
Thanks @sboardwell ! Are you at ease with helm unitest to add some to cover the code in this change? |
|
I can add some. Was a little busy today but wanted to get something in for you to look at. |
|
(btw: you have to bump the chart version in order to have the checks validating your PR) |
|
@dduportal - should be good to go now |
dduportal
reviewed
Sep 25, 2023
Co-authored-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to selectively refresh cached elements.
Inspiration taken from https://bluegrid.io/edu/how-to-purge-the-nginx-cache