Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(acme): fix templating and add unit tests (#655) #715

Merged
merged 3 commits into from
Sep 20, 2023
Merged

fix(acme): fix templating and add unit tests (#655) #715

merged 3 commits into from
Sep 20, 2023

Conversation

linoleparquet
Copy link
Contributor

Related to #655

Hi folks !
Fisrt PR on open source project.
I renamed acme_test_secret to acme-test-secret because helm lint raised a warning.

dduportal
dduportal requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposed contribution!

It is in a good direction but require a bit more work (see my suggestion and comment) as we expect the default unit test suite to not provide any values

charts/acme/tests/defaults_test.yaml Outdated Show resolved Hide resolved
@dduportal dduportal mentioned this pull request Sep 20, 2023
Merged
@dduportal dduportal added bug Something isn't working acme labels Sep 20, 2023
dduportal
dduportal approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks!

@dduportal dduportal merged commit 6976ffc into jenkins-infra:main Sep 20, 2023
2 checks passed
@dduportal dduportal mentioned this pull request Sep 20, 2023
Closed
@linoleparquet linoleparquet mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hervelemeur hervelemeur hervelemeur left review comments

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
acme bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linoleparquet @dduportal @hervelemeur