Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(rsyncd) defer default command to container image #688

Merged
merged 3 commits into from
Sep 8, 2023
Merged

cleanup(rsyncd) defer default command to container image #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5997873
cleanup(rsyncd) defer default command to container image
dduportal Sep 8, 2023
6499ae1
bump chart version
lemeurherve Sep 8, 2023
8c24b88
Merge branch 'main' into cleanup/rsyncd/remove-command-args
lemeurherve Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/rsyncd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v1
description: rsyncd helm chart for Kubernetes
name: rsyncd
version: 1.1.1
version: 1.1.2
2 changes: 0 additions & 2 deletions charts/rsyncd/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ spec:
- name: rsyncd
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
command: ["/bin/tini","--"]
args: ["/usr/bin/rsync", "--verbose", "--no-detach","--daemon","--config","/etc/rsyncd.conf"]
{{- with .Values.containerSecurityContext }}
securityContext:
{{- toYaml . | nindent 12 }}
Expand Down
5 changes: 5 additions & 0 deletions charts/rsyncd/tests/defaults_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ tests:
path: spec.template.spec.containers[0].volumeMounts[3]
- notExists:
path: spec.template.spec.volumes[2]
# No custom entrypoint/command by default
- notExists:
path: spec.template.spec.containers[0].command
- notExists:
path: spec.template.spec.containers[0].args
- it: should create a default rsyncd-conf config map
template: configmap.rsyncd-conf.yaml
asserts:
Expand Down