Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geoipupdates): rbac enhancement to allow rollout restart #1471

Merged
merged 3 commits into from
Dec 12, 2024
Merged

feat(geoipupdates): rbac enhancement to allow rollout restart #1471

merged 3 commits into from
Dec 12, 2024

Conversation

smerle33
Copy link
Contributor

as per jenkins-infra/helpdesk#4441 (comment)
and with jenkins-infra/docker-geoipupdate#20

allow the cronjob to perform a geoipupdate AND a rollout restart of mirrorbits instances.

@smerle33
Copy link
Contributor Author

tested locally with success on k3d:

ROLLOUT RESTART
kubectl -n updates-jenkins-io rollout restart deployment updates-jenkins-io-content-secured-mirrorbits
deployment "updates-jenkins-io-content-secured-mirrorbits" successfully rolled out
deployment.apps/updates-jenkins-io-content-secured-mirrorbits restarted
Waiting for deployment "updates-jenkins-io-content-secured-mirrorbits" rollout to finish: 1 old replicas are pending termination...
Waiting for deployment "updates-jenkins-io-content-secured-mirrorbits" rollout to finish: 1 old replicas are pending termination...
deployment "updates-jenkins-io-content-secured-mirrorbits" successfully rolled out
kubectl -n updates-jenkins-io rollout restart deployment updates-jenkins-io-content-unsecured-mirrorbits
deployment "updates-jenkins-io-content-unsecured-mirrorbits" successfully rolled out
deployment.apps/updates-jenkins-io-content-unsecured-mirrorbits restarted
Waiting for deployment "updates-jenkins-io-content-unsecured-mirrorbits" rollout to finish: 1 old replicas are pending termination...
Waiting for deployment "updates-jenkins-io-content-unsecured-mirrorbits" rollout to finish: 1 old replicas are pending termination...
deployment "updates-jenkins-io-content-unsecured-mirrorbits" successfully rolled out
kubectl -n get-jenkins-io rollout restart deployment get-jenkins-io-mirrorbits
deployment "get-jenkins-io-mirrorbits" successfully rolled out
deployment.apps/get-jenkins-io-mirrorbits restarted
Waiting for deployment "get-jenkins-io-mirrorbits" rollout to finish: 1 old replicas are pending termination...
Waiting for deployment "get-jenkins-io-mirrorbits" rollout to finish: 1 old replicas are pending termination...
deployment "get-jenkins-io-mirrorbits" successfully rolled out
ROLLOUT RESTART DONE

@smerle33 smerle33 marked this pull request as ready for review December 12, 2024 14:34
@smerle33 smerle33 requested a review from dduportal December 12, 2024 14:34
@smerle33 smerle33 merged commit a7064a2 into jenkins-infra:main Dec 12, 2024
3 checks passed
@smerle33 smerle33 mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smerle33 @dduportal