Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(rsyncd): add sshd as an alternative Rsync Daemon to rsyncd #1434

Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 23, 2024

Related to jenkins-infra/helpdesk#4402

This PR adds the support of an alternative rsync backend: sshd in the rsyncd chart.

It introduces a set for changes, which most of them are breaking and requires values updates:

  • BREAKING CHANGE: the default user changes from nobody:nogroup (65534:65534) to rsyncd:rsyncd (1000:1000)
  • BREAKING CHANGE: Default user dir changes from /nowhere to /home/rsyncd
  • BREAKING CHANGE: Default run temp dir for PID files changes from /run to /home/rsyncd/run
  • BREAKING CHANGE: All rsync directories (when using rsyncd) directories (data/, /etc) changes to /home/rsyncd/*
  • Enhancement: allows to use sshd instead of rsyncd, configured by the new value configuration.rsyncd_daemon set to sshd. Otherwise defaults to rsyncd. When enabled:
    • Internally exposed port (pod) changes from 1873 to 2222 (unless specified through the value port)
    • Service exposed port changes from 873 to 22 (unless specified through the value service.port)
    • Bumps the container image to 2.1.0 (ref. jenkins-infra/docker-rsyncd@1.0.68...2.1.0)
    • The public key for the user rsyncd can be specified using the value configuration.sshd.public_key
    • The sshd daemon log level can be set up through the value configuration.sshd.log_level (defaults to INFO)
  • BREAKING CHANGE: deprecate usage of the MotD. The value configuration.motd is now ignored
  • Enhancement: data volumes specified by the configuration.components directive may have writing enabled with the new attribute writeEnabled

BREAKING CHANGE: the value `configuration.motd` is now ignored

Signed-off-by: Damien Duportal <[email protected]>
@dduportal dduportal changed the title feat!: remove MotD settings feat!(rsyncd): add SSH support Nov 24, 2024
@dduportal dduportal changed the title feat!(rsyncd): add SSH support feat!(rsyncd): add sshd as an alternative Rsync Daemon to rsyncd Nov 24, 2024
@dduportal dduportal marked this pull request as ready for review November 24, 2024 07:06
@dduportal dduportal merged commit e08721a into jenkins-infra:main Nov 24, 2024
3 checks passed
@dduportal dduportal deleted the breaking/rsyncd/add-sshd-support branch November 24, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant