Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chart: jenkins-kubernetes-agent "disable token automount" #1074

Merged
merged 4 commits into from
Feb 19, 2024
Merged

chart: jenkins-kubernetes-agent "disable token automount" #1074

merged 4 commits into from
Feb 19, 2024

Conversation

sarathchandra24
Copy link
Contributor

Disable service account token automount for chart: jenkins-kubernetes-agent

#261

dduportal
dduportal requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this contribution!

I've added a suggestion about the version number: I'll let you review and add it, otherwise I'll merge it in 24h with my suggestion (if no answer back).

charts/jenkins-kubernetes-agents/Chart.yaml Outdated Show resolved Hide resolved
dduportal
dduportal approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@dduportal dduportal merged commit fcbfaee into jenkins-infra:main Feb 19, 2024
2 checks passed
@sarathchandra24 sarathchandra24 deleted the disable-token-automount branch February 19, 2024 08:08
@sarathchandra24 sarathchandra24 mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarathchandra24 @dduportal