fix(mirrorbits-lite) remove all mocks from packaged chart

Signed-off-by: Damien Duportal <[email protected]>
jenkins-infra · Oct 4, 2023 · be2bf93 · be2bf93
1 parent 66a5130
commit be2bf93
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/charts/mirrorbits-lite/.helmignore b/charts/mirrorbits-lite/.helmignore
@@ -20,4 +20,4 @@
 .idea/
 *.tmproj
 .vscode/
-tests/*
+tests/
diff --git a/charts/mirrorbits-lite/Chart.yaml b/charts/mirrorbits-lite/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: Mirrobits lite helm chart for Kubernetes
 name: mirrorbits-lite
-version: 0.3.0
+version: 0.3.1
 appVersion: "v0.5.1"
 maintainers:
 - email: [email protected]

diff --git a/charts/mirrorbits-lite/templates/_helpers.tpl b/charts/mirrorbits-lite/templates/_helpers.tpl
@@ -49,14 +49,14 @@ Data directory volume definition. Might be defined from parent chart templates o
 based on the presence of the global value provided by the parent chart.
 */}}
 {{- define "mirrorbits-lite.data-volume" -}}
-{{- if (dig "global" "storage" "enabled" false .Values.AsMap) -}}
+{{- if and (dig "global" "storage" "enabled" false .Values.AsMap) .Values.global.storage.claimNameTpl -}}
 persistentVolumeClaim:
-  claimName: {{ include "mirrorbits-parent.pvc-name" . }}
-{{- else }}
-  {{- if .Values.repository.persistentVolumeClaim.enabled }}
+  claimName: {{ printf "%s" (tpl .Values.global.storage.claimNameTpl $) | trim | trunc 63 }}
+{{- else -}}
+  {{- if .Values.repository.persistentVolumeClaim.enabled -}}
 persistentVolumeClaim:
   claimName: {{ .Values.repository.name | default (printf "%s-binary" (include "mirrorbits-lite.fullname" .)) }}
-  {{- else }}
+  {{- else -}}
 emptyDir: {}
   {{- end -}}
 {{- end -}}

diff --git a/charts/mirrorbits-lite/templates/mocks/_helpers.tpl b/charts/mirrorbits-lite/templates/mocks/_helpers.tpl
diff --git a/charts/mirrorbits-lite/tests/parent_values_test.yaml b/charts/mirrorbits-lite/tests/parent_values_test.yaml
@@ -10,6 +10,7 @@ set:
   global:
     storage:
       enabled: true
+      claimNameTpl: '{{ default "parent-chart-shared-data" }}'
     ingress:
       enabled: true
   # Try to specify a ingress which must be ignored (parent prevails)
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,4 +20,4 @@ @@
     .idea/
     *.tmproj
     .vscode/
-    tests/*
+    tests/