add a unittest for selector and cleanup volumes and resources

charts/javadoc/templates/deployment.yaml

@@ -51,8 +51,10 @@ spec:
               mountPath: /usr/share/nginx/html
             - name: config
               mountPath: /etc/nginx/conf.d
+          {{- with .Values.resources }}
           resources:
-            {{- toYaml .Values.resources | nindent 12 }}
+            {{- toYaml . | nindent 12 }}
+          {{- end }}
       {{- with .Values.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}
@@ -67,7 +69,11 @@ spec:
     {{- end }}
       volumes:
         - name: html
+        {{- if .Values.htmlVolume }}
 {{ toYaml .Values.htmlVolume | indent 10 }}
+        {{- else }}
+          emptyDir: {}
+        {{- end }}
         - name: config
           configMap:
             name: javadoc

charts/javadoc/tests/defaults_test.yaml

@@ -1,9 +1,34 @@
 suite: default tests
 templates:
   - pdb.yaml
+  - deployment.yaml
+  - nginx-configmap.yaml
 tests:
   - it: should not generate any pdb with default values
     template: pdb.yaml
     asserts:
       - hasDocuments:
           count: 0
+  - it: Should generate a deployment with the default values
+    template: deployment.yaml
+    asserts:
+      - hasDocuments:
+          count: 1
+      - isKind:
+          of: Deployment
+      - notExists:
+          path: spec.affinity
+      - equal:
+          path: metadata.labels["app.kubernetes.io/name"]
+          value: javadoc
+      - equal:
+          path: metadata.labels["app.kubernetes.io/managed-by"]
+          value: Helm
+      - equal:
+          path: spec.template.spec.volumes[0].name
+          value: html
+      - equal:
+          path: spec.template.spec.volumes[0].emptyDir
+          value: {}
+      - notExists:
+          path: spec.template.spec.containers[0].resources