feat(rsyncd) allow overriding PV(C)s based on global value from paren…

…t chart

Signed-off-by: Damien Duportal <[email protected]>

charts/rsyncd/.helmignore

@@ -14,6 +14,7 @@
 *.swp
 *.bak
 *.tmp
+*.orig
 *~
 # Various IDEs
 .project

charts/rsyncd/Chart.yaml

@@ -1,4 +1,7 @@
 apiVersion: v1
 description: rsyncd helm chart for Kubernetes
 name: rsyncd
-version: 1.3.2
+version: 1.4.0
+maintainers:
+- email: [email protected]
+  name: jenkins-infra-team

charts/rsyncd/templates/_helpers.tpl

@@ -43,3 +43,22 @@ app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
 {{- end }}
 app.kubernetes.io/managed-by: {{ .Release.Service }}
 {{- end -}}
+
+
+{{/*
+Data directory volume definition. Might be defined from parent chart templates or autonomously
+based on the presence of the global value provided by the parent chart.
+Expected argument: dict{
+  "currentRsyncComponent": <string>,
+  "rootContext": { },
+}
+*/}}
+{{- define "rsync.datadir-volumedef" -}}
+{{- if .currentRsyncComponent.volumeTpl -}}
+  {{- printf "%s" (tpl .currentRsyncComponent.volumeTpl .rootContext) | trim | trunc 63 }}
+{{- else if .currentRsyncComponent.volume -}}
+  {{- toYaml .currentRsyncComponent.volume -}}
+{{- else -}}
+emptyDir: {}
+{{- end -}}
+{{- end -}}

charts/rsyncd/templates/deployment.yaml

@@ -94,9 +94,5 @@ spec:
             sizeLimit: 32Mi
         {{- range .Values.configuration.components }}
         - name: datadir-{{ .name }}
-          {{- if .volume }}
-            {{- toYaml .volume  | nindent 10 }}
-          {{- else }}
-          emptyDir:
-          {{ end }}
+          {{- include "rsync.datadir-volumedef" (dict "currentRsyncComponent" . "rootContext" .) | nindent 10 }}
         {{- end }}