cleanup(rsyncd) defer default command to container image (#688)

* cleanup(rsyncd) defer default command to container image Signed-off-by: Damien Duportal <[email protected]> * bump chart version --------- Signed-off-by: Damien Duportal <[email protected]> Co-authored-by: Hervé Le Meur <[email protected]>
jenkins-infra · Sep 8, 2023 · 96d9fb3 · 96d9fb3
1 parent fa521ca
commit 96d9fb3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/charts/rsyncd/Chart.yaml b/charts/rsyncd/Chart.yaml
@@ -1,4 +1,4 @@
 apiVersion: v1
 description: rsyncd helm chart for Kubernetes
 name: rsyncd
-version: 1.1.1
+version: 1.1.2
diff --git a/charts/rsyncd/templates/deployment.yaml b/charts/rsyncd/templates/deployment.yaml
@@ -29,8 +29,6 @@ spec:
         - name: rsyncd
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
-          command: ["/bin/tini","--"]
-          args: ["/usr/bin/rsync", "--verbose", "--no-detach","--daemon","--config","/etc/rsyncd.conf"]
           {{- with .Values.containerSecurityContext }}
           securityContext:
             {{- toYaml . | nindent 12 }}

diff --git a/charts/rsyncd/tests/defaults_test.yaml b/charts/rsyncd/tests/defaults_test.yaml
@@ -77,6 +77,11 @@ tests:
           path: spec.template.spec.containers[0].volumeMounts[3]
       - notExists:
           path: spec.template.spec.volumes[2]
+      # No custom entrypoint/command by default
+      - notExists:
+          path: spec.template.spec.containers[0].command
+      - notExists:
+          path: spec.template.spec.containers[0].args
   - it: should create a default rsyncd-conf config map
     template: configmap.rsyncd-conf.yaml
     asserts: