code review

Signed-off-by: Damien Duportal <[email protected]>
jenkins-infra · Oct 6, 2023 · 12c9b94 · 12c9b94
1 parent cb471ff
commit 12c9b94
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 16 deletions.
diff --git a/charts/plugin-site/tests/custom_values_test.yaml b/charts/plugin-site/tests/custom_values_test.yaml
@@ -36,21 +36,7 @@ tests:
       - equal:
           path: spec.template.spec.containers[0].resources.limits.cpu
           value: 300ms
-  - it: should create a PDB with defaults when multiple replicas are set
-    template: pdb-frontend.yaml
-    set:
-      frontend:
-        replicaCount: 4
-    asserts:
-      - isKind:
-          of: PodDisruptionBudget
-      - equal:
-          path: spec.minAvailable
-          value: 1
-      - equal:
-          path: spec.selector.matchLabels['app.kubernetes.io/name']
-          value: "plugin-site-frontend"
-  - it: should ensure the pdb has correct spec
+  - it: should create a customized PDB with the provided spec
     template: pdb-frontend.yaml
     set:
       frontend:

diff --git a/charts/plugin-site/tests/defaults_values_test.yaml b/charts/plugin-site/tests/defaults_values_test.yaml
@@ -35,8 +35,16 @@ tests:
       - equal:
           path: spec.template.spec.containers[0].resources.limits.cpu
           value: 100m
-  - it: should generate a pdb with default values
+  - it: should create a pdb with default values as the frontend service is replicated to 2 by default
     template: pdb-frontend.yaml
     asserts:
       - hasDocuments:
           count: 1
+      - isKind:
+          of: PodDisruptionBudget
+      - equal:
+          path: spec.minAvailable
+          value: 1
+      - equal:
+          path: spec.selector.matchLabels['app.kubernetes.io/name']
+          value: "plugin-site-frontend"