-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dlcdn instead of downloads.apache.org #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #39?
@@ -88,7 +88,7 @@ jobs: | |||
# https://github.com/jenkins-infra/github-reusable-workflows/issues/36 | |||
- name: Set up Maven | |||
run: | | |||
wget --no-verbose https://downloads.apache.org/maven/maven-3/$MAVEN_VERSION/binaries/apache-maven-$MAVEN_VERSION-bin.tar.gz | |||
wget --no-verbose https://dlcdn.apache.org/maven/maven-3/$MAVEN_VERSION/binaries/apache-maven-$MAVEN_VERSION-bin.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/$MAVEN_VERSION/apache-maven-$MAVEN_VERSION-bin.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since dlcdn.apache.org is the download URL provided by https://maven.apache.org/download.cgi , I think it is the better choice than using the Apache artifact repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR https://repo.maven.apache.org/maven2
is the URL provided by default by Apache Maven distribution in the super pom. So, it's the URL used by any default Apache Maven distribution and used by mvnw
as well.
It's a CNAME to Maven Central.
If you prefer using something else, that is fine, but Maven Central will scale more and be more reliable than Apache Mirrors, which can fail and even be outdated.
Apache INFRA is always happy to have load reduced, so using Maven Central could reduce load on limited Apache INFRA resources.
Worth a try?
I've checked and older versions are there too its not just the latest version like it used to be.
(I've checked and the IPs are different to download so it is something different
I think this should be more reliable as its a mirror network instead of an archive? https://infra.apache.org/release-publishing.html
relates to #40