here-docs code improvement for GHA summary to maven-cd.yml runs (#33) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t wrapper with single quotessingle quote Co-authored-by: Jesse Glick <[email protected]>
…a in a single line Co-authored-by: Jesse Glick <[email protected]>
|
@jglick Let me do another test run before merging. |
@jglick - it is tested and working as expected! Many thanks for your input! For test result please look at: https://github.com/mavenplugins/jenkins-unleash-plugin-fork/actions/runs/10965939050 |
jglick
approved these changes
Sep 20, 2024
|
@timja - FYI - should be released when there is some time. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jglick - Following your comment on #33
No functional change
Test
s. https://github.com/mavenplugins/jenkins-unleash-plugin-fork/actions/runs/10962303075
tested after code improvements co-authored by @jglick :
https://github.com/mavenplugins/jenkins-unleash-plugin-fork/actions/runs/10965939050