feat(trusted.ci) set up PLS and PEs for agents #891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref jenkins-infra/helpdesk#4402 (comment)
This PR adds an Azure Private Endpoint in the subnet of the ephemeral agents to allow the crawler job to reach the Update Center Rsync Data service.
It utilizes a local module (no need to share this module outside the repository as it's only used here) to encapsulate the logic and allow passing providers (ephemeral agents and PLS are not in the same subscription, which requires multiple providers. But providers cannot be resolved dynamically so no
for_each
solution).It also removes the existing private DNS zone used to provide private access to the container ACR, as only 1 private zone can be linked to a given virtual network. trusted.ci does not have container caching anymore. We might be able to re-create a new endpoint and add a custom records, but the configuration will have to be changed.
Edit: 2 hotfixes were required: