Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trusted.ci) set up PLS and PEs for agents #891

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 28, 2024

Ref jenkins-infra/helpdesk#4402 (comment)

This PR adds an Azure Private Endpoint in the subnet of the ephemeral agents to allow the crawler job to reach the Update Center Rsync Data service.

It utilizes a local module (no need to share this module outside the repository as it's only used here) to encapsulate the logic and allow passing providers (ephemeral agents and PLS are not in the same subscription, which requires multiple providers. But providers cannot be resolved dynamically so no for_each solution).

It also removes the existing private DNS zone used to provide private access to the container ACR, as only 1 private zone can be linked to a given virtual network. trusted.ci does not have container caching anymore. We might be able to re-create a new endpoint and add a custom records, but the configuration will have to be changed.


Edit: 2 hotfixes were required:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant