Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test.ci.jenkins.io):Extend Azure SP credentials end-date #821

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

jayfranco999
Copy link
Contributor

As per jenkins-infra/helpdesk#4124 (comment)

This PR allows me to create Azure VM ssh agents for maven17 and maven21 with my local vagrant controller (hence the extension)

@jayfranco999 jayfranco999 changed the title feat(test.ci.jenkins.io):Extends Azure SP credentials end-date feat(test.ci.jenkins.io):Extend Azure SP credentials end-date Sep 5, 2024
smerle33
smerle33 previously approved these changes Sep 5, 2024
Copy link
Collaborator

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

test.ci.jenkins.io.tf Outdated Show resolved Hide resolved
@smerle33
Copy link
Collaborator

smerle33 commented Sep 5, 2024

Plan: 1 to add, 0 to change, 1 to destroy.

Copy link
Collaborator

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this time it looks better :

Plan: 1 to add, 0 to change, 1 to destroy.

@smerle33 smerle33 merged commit 6d80281 into jenkins-infra:main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants