Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all github-comment-op commands except /reviewer #15

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

@timja timja requested review from lemeurherve and a team and removed request for lemeurherve August 1, 2022 08:55
Copy link

@hervelemeur hervelemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected to add only the command to enable to the config but it's fine as it is already.

Thanks @timja!

@timja
Copy link
Member Author

timja commented Aug 1, 2022

I would have expected to add only the command to enable to the config but it's fine as it is already.

Thanks @timja!

they default to enabled currently, possibly should default to off so new commands don't get accidentally enabled, anyway this is explicit in what is there

@hervelemeur
Copy link

Default to off seems better, and complete explicit listing is totally appropriate here indeed.

@timja
Copy link
Member Author

timja commented Aug 1, 2022

@timja timja merged commit 473fe58 into master Aug 1, 2022
@timja timja deleted the timja-patch-1 branch August 1, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants