-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap in tomllib/tomli for toml. #340
Conversation
Fixes jendrikseipp#339 -- the toml package does not support heterogenous arrays, which are now allowed in the toml spec. This commit swaps in tomllib from the standard library for Python >= 3.11 and its backport tomli for older versions.
Note: While the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Code looks good, I only have a few minor nitpicks.
Co-authored-by: Jendrik Seipp <[email protected]>
It turns out this isn't a conflict with
When run from a 3.8 virtualenv, flake8 is happy. I was getting failures only from pre-commit because I had installed It turns out that if you use tl;dr @jendrikseipp I think the fix is just to bump flake8 in |
Thanks for the changes and for looking into the flake8 issue! I'll merge this as is to have a clean history. Would be great if you could send another PR for the flake8 issue. |
Description
Fixes #339 -- the toml package does not support heterogenous arrays, which are now allowed in the toml spec. This commit swaps in tomllib from the standard library for Python >= 3.11 and its backport tomli for older versions.
Checklist:
tox -e fix-style
to format my code and checked the result withtox -e style
.