Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queue when playing on remote device (partial) #3381

Merged
merged 14 commits into from
Oct 17, 2024

Conversation

AER00
Copy link
Contributor

@AER00 AER00 commented Feb 4, 2022

Changes
Many queue specific features was missing when using remote play (casting). This commit enables showing queue from remote device, and implements (really) basic queue management. There is still a lot of things to improve.

Issues
Unfortunately, it's currently not possible to manage queue fully remotely without implementing some new endpoints in the API, such as go to nth item of current playlist, or move / remove an item without stopping current playback.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill added the bug Something isn't working label Mar 1, 2022
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Mar 2, 2022
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Dec 10, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@thornbill thornbill added this to the v10.9.0 milestone Jan 12, 2024
@thornbill thornbill modified the milestones: v10.9.0, v10.10.0 May 1, 2024
@AER00 AER00 requested a review from a team as a code owner May 11, 2024 18:14
@thornbill thornbill added enhancement Improve existing functionality or small fixes and removed bug Something isn't working labels May 18, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/plugins/sessionPlayer/plugin.js Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/sessionPlayer/plugin.js Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@danditomaso
Copy link

@AER00 I'm helping out the Jellyfin-web team with reviewing some of these older PR's so we can get on top of the backlog. Wanted to follow up with you and see if some of these ESLint warnings can be resolved? If so, it wont take long to get this merged after it has been tested.

@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 15, 2024

Cloudflare Pages deployment

Latest commit ae7555a
Status ✅ Deployed!
Preview URL https://0072b722.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

Copy link

@thornbill thornbill merged commit 8b3a02c into jellyfin:master Oct 17, 2024
14 checks passed
kevgrig pushed a commit to kevgrig/jellyfin-web that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants