refactor: Update subtitle streams to use TextTrack indexes #2529
Conversation
Cloudflare Pages deployment
|
|
Hmm, Not sure why but it seems that when you add a External subtitle, and then attempt to play, the subtitles are off by 1...
When you select English (SDH) It seems like the Delivery VTT is incorrect. Unsure if this is related to this change, or has always been an issue with external subtitles? Nevermind, this part is a bug in Jellyfin, as is occurring in the official UI. |
|
@EffakT Thank you very much for yet another contribution :) So, beside the server bug, does this make Vue behave 1:1 like Jellyfin Web? Is there a ticket opened in server for this? A TODO comment with a reference to the server issue created would be very welcome, so we are aware of this bug until it's properly fixed. Imagine if later on I (or someone else) want to refactor/improve the subtitle logic a little, not remembering this PR will drive me nuts :). |
|
Sure, will make a issue in Jellyfin Server. |
|
From my testing, this now behaves 1:1 like Jellyfin Web. Have made a issue in Jellyfin Server I've put the TODO comment into the currentItemParsedSubtitleTracks, as this is where you are most likely to see the comment when refactoring the subtitle code. |
ferferga
force-pushed
the
subtitle-indexes-fix
branch
from
d2c9b82 to
c9060b3
Compare
|
Subtitles were using the MediaStream index to select what subtitles to play, rather than the TextTrack index.
This meant that the subtitles were playing incorrectly as it was taking into account the Video/Audio streams when selecting a subtitle.
E.G:
English 1
English 2
English (SDH)
Bulgarian
CZE
When selecting English 1, This plays the English (SDH).
When selecting English 2, This plays Bulgarian.
When selecting English (SDH), This plays CZE.
This is because the MediaStreams are:
Video
Audio
English 1
English 2
etc...
This PR refactors the subtitle selection code to set the Index and srcIndex to be based on the TextStream, instead of the MediaStream.
resolves #2519