Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle selector is playing incorrect subtitles #2519

Closed
EffakT opened this issue Dec 2, 2024 · 0 comments · Fixed by #2529
Closed

Subtitle selector is playing incorrect subtitles #2519

EffakT opened this issue Dec 2, 2024 · 0 comments · Fixed by #2529
Labels
bug Something isn't working

Comments

@EffakT
Copy link
Contributor

EffakT commented Dec 2, 2024

Description of the bug

When playing a video with multiple subtitles, The subtitle selection is off by 2.
E.G:

  1. English 1
  2. English 2
  3. English (SDH)
  4. Bulgarian
  5. CZE

When selecting English 1, This plays the English (SDH).
When selecting English 2, This plays Bulgarian.
When selecting English (SDH), This plays CZE.

These subtitles are embedded, have yet to try external subtitles.

I'm wondering if it is taking into account the video and audio streams when selecting the subtitles.
So:
English 1 actually has ID 2 instead of ID 0,
English 2 has ID 3 instead of 1, etc.

The currentItemParsesSubtitleTracks should actually be filtering out non subtitles, and then map the indexes into the object.
So:

MediaStreams?.filter.map()

Instead of

MediaStreams?.map().filter

Steps to reproduce

  1. Load a video with a bunch of subtitles
  2. Select a subtitle
  3. The incorrect subtitle plays.

Expected behavior

Selecting the English (SDH) subtitle, should play the English (SDH) subtitle, not the CZE subtitle.

Logs


Screenshots

No response

Platform

macOS

Browser

Firefox

Jellyfin server version

10.10.3

Additional context


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant