Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing season type 'alttwo' #200

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

Kianda
Copy link
Contributor

@Kianda Kianda commented Dec 10, 2024

There are currently 7 types but here on jellyfin-plugin-tvdb only 6 are supported.
I've just added the one missing ^^

FYI: Here is the payload from thetvdb.com API v4 (seasons/types)

Swagger:
https://thetvdb.github.io/v4-api/
{
  "status": "success",
  "data": [
    {
      "id": 1,
      "name": "Aired Order",
      "type": "official",
      "alternateName": null
    },
    {
      "id": 2,
      "name": "DVD Order",
      "type": "dvd",
      "alternateName": null
    },
    {
      "id": 3,
      "name": "Absolute Order",
      "type": "absolute",
      "alternateName": null
    },
    {
      "id": 4,
      "name": "Alternate Order",
      "type": "alternate",
      "alternateName": null
    },
    {
      "id": 5,
      "name": "Regional Order",
      "type": "regional",
      "alternateName": null
    },
    {
      "id": 6,
      "name": "Alternate DVD Order",
      "type": "altdvd",
      "alternateName": null
    },
    {
      "id": 7,
      "name": "Alternate Order 2",
      "type": "alttwo",
      "alternateName": null
    }
  ]
}

@scampower3
Copy link
Member

scampower3 commented Dec 14, 2024

Probably needs additional modifications to jellyfin-web like jellyfin/jellyfin-web#5505

@Kianda
Copy link
Contributor Author

Kianda commented Dec 14, 2024

Yes true, it needs additional modifications to jellyfin-web but it's not mandatory.
The current downside is that you must provide the 'alttwo' order inside the tvshow.nfo cause it's not available from the GUI.

Example of tvshow.nfo

<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <tvshow> <displayorder>alttwo</displayorder> </tvshow>

jellyfin-plugin-tvdb will read this without any issues!

More info: https://jellyfin.org/docs/general/server/metadata/nfo/#naming-nfo-files

@crobibero crobibero added the feature This PR or Issue requests or introduces a new feature label Dec 14, 2024
@crobibero crobibero merged commit d62e613 into jellyfin:master Dec 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This PR or Issue requests or introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants