Make Tvdb Client usage more resilient and robust #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobSilent
force-pushed
the
make-tvdb-v4api-call-more-robust
branch
from
d8af3a3 to
5e346e5
Compare
crobibero
approved these changes
Feb 29, 2024
Merged
Shadowghost
added a commit
that referenced
this pull request
Feb 29, 2024
Improvements and fixes tvdb sdk 4.7.9.1 + PR #112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Client calls more resilient and robust by catching in some situations a serialization
JsonExceptionand return and empty ornullvalue, instead of ignoring the exception.See also #111
I also made a cleanup of
TvdbSeasonImageProviderandTvdbSeriesImageProvider, which shared some common code. Will do here further steps in a different PR.