refactor: set custom DNS server only once #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time an HTTP client is created, an attempt is made to modify the `dialer.Resolver`. So now it only attempts to change the `dialer.Resolver` once when necessary (e.g. by passing the `-dns` parameter or running the `WaitForNetworkConnected` function). Also, rename `dns.go` and `dns_test.go` to `net_resolver.go` and `net_resolver_test.go` --- Move `wait_net.go` to the `internal` package to prevent it from being mistaken as a DNS provider. Ignore false positive.
|
SkipVerfiry也可以参考这个思路修改下吧？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set custom DNS server only once.
Motivation
Poorly written code in #682.
Additional Notes
Every time an HTTP client is created, an attempt is made to modify the
dialer.Resolver.So now it only attempts to change the
dialer.Resolveronce when necessary (e.g. by passing the-dnsparameter or running theWaitForNetworkConnectedfunction).Also, rename
dns.goanddns_test.gotonet_resolver.goandnet_resolver_test.goMove
wait_net.goto theinternalpackage to prevent it from being mistaken as a DNS provider.Ignore false positive.