fix(rtd): remove flyout in iframes (#367)

* fix(rtd): remove flyout in iframes * fix(rtd): remove dirhtml and default to html Because dirhtml seems to have issues with iframes * fix(html): correct css style
jeertmans · Feb 1, 2024 · b47068e · b47068e
1 parent 973522a
commit b47068e
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 22 deletions.
diff --git a/.readthedocs.yaml b/.readthedocs.yaml
@@ -10,7 +10,7 @@ build:
     post_install:
     - ipython kernel install --name "manim-slides" --user
 sphinx:
-  builder: dirhtml
+  builder: html
   configuration: docs/source/conf.py
   fail_on_warning: true
 python:

diff --git a/manim_slides/convert.py b/manim_slides/convert.py
@@ -416,6 +416,7 @@ def convert_to(self, dest: Path) -> None:
                 file_to_data_uri=file_to_data_uri,
                 get_duration_ms=get_duration_ms,
                 has_notes=has_notes,
+                env=os.environ,
                 **options,
             )
 

diff --git a/manim_slides/templates/revealjs.html b/manim_slides/templates/revealjs.html
@@ -316,28 +316,36 @@
         hideCursorTime: {{ hide_cursor_time }}
       });
 
-      {% if data_uri %}
-        // Fix found by @t-fritsch on GitHub
-        // see: https://github.com/hakimel/reveal.js/discussions/3362#discussioncomment-6651475.
-        function fixBase64VideoBackground(event) {
-          // event.previousSlide, event.currentSlide, event.indexh, event.indexv
-          if (event.currentSlide.getAttribute('data-background-video')) {
-            const background = Reveal.getSlideBackground(event.indexh, event.indexv),
-              video = background.querySelector('video'),
-              sources = video.querySelectorAll('source');
-
-            sources.forEach((source, i) => {
-              const src = source.getAttribute('src');
-              if(src.match(/^data:video.*;base64$/)) {
-                const nextSrc = sources[i+1]?.getAttribute('src');
-                video.setAttribute('src', `${src},${nextSrc}`);
-              }
-            });
-          }
+      {% if data_uri -%}
+      // Fix found by @t-fritsch on GitHub
+      // see: https://github.com/hakimel/reveal.js/discussions/3362#discussioncomment-6651475.
+      function fixBase64VideoBackground(event) {
+        // event.previousSlide, event.currentSlide, event.indexh, event.indexv
+        if (event.currentSlide.getAttribute('data-background-video')) {
+          const background = Reveal.getSlideBackground(event.indexh, event.indexv),
+            video = background.querySelector('video'),
+            sources = video.querySelectorAll('source');
+
+          sources.forEach((source, i) => {
+            const src = source.getAttribute('src');
+            if(src.match(/^data:video.*;base64$/)) {
+              const nextSrc = sources[i+1]?.getAttribute('src');
+              video.setAttribute('src', `${src},${nextSrc}`);
+            }
+          });
         }
-        Reveal.on( 'ready', fixBase64VideoBackground );
-        Reveal.on( 'slidechanged', fixBase64VideoBackground );
-      {% endif %}
+      }
+      Reveal.on( 'ready', fixBase64VideoBackground );
+      Reveal.on( 'slidechanged', fixBase64VideoBackground );
+      {%- endif %}
     </script>
+
+    {% if env['READTHEDOCS'] -%}
+    <style>
+      readthedocs-flyout, readthedocs-notification {
+        display: none;
+      }
+    </style>
+    {%- endif %}
   </body>
 </html>