Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More customization options, bug fixes, and future compatibility. #69

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

More customization options, bug fixes, and future compatibility. #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
bf5e4ef
Migrated to Swift 5 and removed all the errors when setting minimum d…
Jan 25, 2021
7d71abb
Changed the arrow "label" to a UIImage view to increase customizabili…
Jan 26, 2021
9bcad97
Changed the animation into a CGAffine transform animation and fixed t…
Jan 26, 2021
96fee0e
Added the missing animation for the arrow going back when collapsing.
Jan 26, 2021
22df8aa
Added section background color customization.
Jan 26, 2021
f49bea6
Added section alignment option to change the alignment of the entire …
shadow-of-arman Jan 26, 2021
187a003
Added documentation for the added options.
shadow-of-arman Jan 26, 2021
6501554
Added minimum development version support for iOS 9 and higher.
shadow-of-arman Jan 26, 2021
34fff98
Update .travis.yml
shadow-of-arman Jan 26, 2021
ffc3893
Update XCTests
shadow-of-arman Jan 26, 2021
9d605ea
Update .travis.yml
shadow-of-arman Jan 26, 2021
30887a4
Update .travis.yml
shadow-of-arman Jan 26, 2021
88ade2d
Update .travis.yml
shadow-of-arman Jan 26, 2021
41aa214
update .travis.yml
shadow-of-arman Jan 26, 2021
e71eebb
Update .travis.yml
shadow-of-arman Jan 26, 2021
8ee4ba8
Update .travis.yml
shadow-of-arman Jan 26, 2021
25f3b64
Added the ability to change the background color of the table view.
shadow-of-arman Jan 31, 2021
4138da2
Added row height and separator style to customize.
shadow-of-arman Jan 31, 2021
6d23805
Added a register function to register cells for the tableview
shadow-of-arman Jan 31, 2021
f162754
no message
shadow-of-arman Jan 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: objective-c
osx_image: xcode10.1
osx_image: xcode12
script:
- xcodebuild test -project CollapsibleTableSectionViewController.xcodeproj -scheme CollapsibleTableSectionViewController -destination 'platform=iOS Simulator,name=iPhone 7'
- xcodebuild test -project CollapsibleTableSectionViewController.xcodeproj -scheme CollapsibleTableSectionViewController -destination 'platform=iOS Simulator,name=iPhone X,OS=12.1' build test
after_success:
- bash <(curl -s https://codecov.io/bash)
- bash <(curl -s https://codecov.io/bash)
81 changes: 68 additions & 13 deletions CollapsibleTableSectionViewController.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
0A8BD67D1F231B2C003D6155 /* CollapsibleTableSectionViewController.h in Headers */ = {isa = PBXBuildFile; fileRef = 0A8BD66F1F231B2C003D6155 /* CollapsibleTableSectionViewController.h */; settings = {ATTRIBUTES = (Public, ); }; };
0A8BD68A1F231DF2003D6155 /* CollapsibleTableSectionViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0A8BD6861F231DF2003D6155 /* CollapsibleTableSectionViewController.swift */; };
0A8BD68C1F231DF2003D6155 /* CollapsibleTableViewHeader.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0A8BD6881F231DF2003D6155 /* CollapsibleTableViewHeader.swift */; };
45748F0225BEE9D100674BB2 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 45748F0125BEE9D100674BB2 /* Assets.xcassets */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand All @@ -22,6 +23,13 @@
remoteGlobalIDString = 0A8BD66B1F231B2C003D6155;
remoteInfo = CollapsibleTableSectionViewController;
};
45748ECC25BEB80C00674BB2 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 45748EC825BEB80C00674BB2 /* Examples.xcodeproj */;
proxyType = 2;
remoteGlobalIDString = 0AC886DB1F226627007E4E2F;
remoteInfo = Examples;
};
/* End PBXContainerItemProxy section */

/* Begin PBXFileReference section */
Expand All @@ -33,6 +41,8 @@
0A8BD67C1F231B2C003D6155 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
0A8BD6861F231DF2003D6155 /* CollapsibleTableSectionViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CollapsibleTableSectionViewController.swift; sourceTree = "<group>"; };
0A8BD6881F231DF2003D6155 /* CollapsibleTableViewHeader.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CollapsibleTableViewHeader.swift; sourceTree = "<group>"; };
45748EC825BEB80C00674BB2 /* Examples.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = Examples.xcodeproj; path = Examples/Examples.xcodeproj; sourceTree = "<group>"; };
45748F0125BEE9D100674BB2 /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -60,6 +70,7 @@
0A8BD66E1F231B2C003D6155 /* CollapsibleTableSectionViewController */,
0A8BD6791F231B2C003D6155 /* CollapsibleTableSectionViewControllerTests */,
0A8BD66D1F231B2C003D6155 /* Products */,
45748EC825BEB80C00674BB2 /* Examples.xcodeproj */,
);
sourceTree = "<group>";
};
Expand All @@ -75,9 +86,10 @@
0A8BD66E1F231B2C003D6155 /* CollapsibleTableSectionViewController */ = {
isa = PBXGroup;
children = (
0A8BD66F1F231B2C003D6155 /* CollapsibleTableSectionViewController.h */,
0A8BD6861F231DF2003D6155 /* CollapsibleTableSectionViewController.swift */,
0A8BD6881F231DF2003D6155 /* CollapsibleTableViewHeader.swift */,
0A8BD66F1F231B2C003D6155 /* CollapsibleTableSectionViewController.h */,
45748F0125BEE9D100674BB2 /* Assets.xcassets */,
0A8BD6701F231B2C003D6155 /* Info.plist */,
);
path = CollapsibleTableSectionViewController;
Expand All @@ -92,6 +104,14 @@
path = CollapsibleTableSectionViewControllerTests;
sourceTree = "<group>";
};
45748EC925BEB80C00674BB2 /* Products */ = {
isa = PBXGroup;
children = (
45748ECD25BEB80C00674BB2 /* Examples.app */,
);
name = Products;
sourceTree = "<group>";
};
/* End PBXGroup section */

/* Begin PBXHeadersBuildPhase section */
Expand Down Expand Up @@ -148,32 +168,42 @@
0A8BD6631F231B2C003D6155 /* Project object */ = {
isa = PBXProject;
attributes = {
KnownAssetTags = (
1,
);
LastSwiftUpdateCheck = 0830;
LastUpgradeCheck = 1010;
LastUpgradeCheck = 1230;
ORGANIZATIONNAME = jeantimex;
TargetAttributes = {
0A8BD66B1F231B2C003D6155 = {
CreatedOnToolsVersion = 8.3.3;
LastSwiftMigration = 1010;
LastSwiftMigration = 1230;
ProvisioningStyle = Automatic;
};
0A8BD6741F231B2C003D6155 = {
CreatedOnToolsVersion = 8.3.3;
LastSwiftMigration = 1010;
DevelopmentTeam = 589RNFRDJ2;
LastSwiftMigration = 1230;
ProvisioningStyle = Automatic;
};
};
};
buildConfigurationList = 0A8BD6661F231B2C003D6155 /* Build configuration list for PBXProject "CollapsibleTableSectionViewController" */;
compatibilityVersion = "Xcode 3.2";
developmentRegion = English;
developmentRegion = en;
hasScannedForEncodings = 0;
knownRegions = (
en,
);
mainGroup = 0A8BD6621F231B2C003D6155;
productRefGroup = 0A8BD66D1F231B2C003D6155 /* Products */;
projectDirPath = "";
projectReferences = (
{
ProductGroup = 45748EC925BEB80C00674BB2 /* Products */;
ProjectRef = 45748EC825BEB80C00674BB2 /* Examples.xcodeproj */;
},
);
projectRoot = "";
targets = (
0A8BD66B1F231B2C003D6155 /* CollapsibleTableSectionViewController */,
Expand All @@ -182,11 +212,22 @@
};
/* End PBXProject section */

/* Begin PBXReferenceProxy section */
45748ECD25BEB80C00674BB2 /* Examples.app */ = {
isa = PBXReferenceProxy;
fileType = wrapper.application;
path = Examples.app;
remoteRef = 45748ECC25BEB80C00674BB2 /* PBXContainerItemProxy */;
sourceTree = BUILT_PRODUCTS_DIR;
};
/* End PBXReferenceProxy section */

/* Begin PBXResourcesBuildPhase section */
0A8BD66A1F231B2C003D6155 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
45748F0225BEE9D100674BB2 /* Assets.xcassets in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -232,6 +273,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
Expand All @@ -253,6 +295,7 @@
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
Expand All @@ -262,6 +305,7 @@
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = dwarf;
EMBED_ASSET_PACKS_IN_PRODUCT_BUNDLE = YES;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
Expand All @@ -281,6 +325,7 @@
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
RESOURCES_TARGETED_DEVICE_FAMILY = "";
SDKROOT = iphoneos;
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
Expand All @@ -294,6 +339,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
Expand All @@ -315,6 +361,7 @@
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
Expand All @@ -324,6 +371,7 @@
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
EMBED_ASSET_PACKS_IN_PRODUCT_BUNDLE = YES;
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
Expand All @@ -336,6 +384,7 @@
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
MTL_ENABLE_DEBUG_INFO = NO;
RESOURCES_TARGETED_DEVICE_FAMILY = "";
SDKROOT = iphoneos;
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
TARGETED_DEVICE_FAMILY = "1,2";
Expand All @@ -351,9 +400,11 @@
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "";
DEFINES_MODULE = YES;
DEVELOPMENT_ASSET_PATHS = CollapsibleTableSectionViewController/Assets.xcassets;
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
ENABLE_ON_DEMAND_RESOURCES = NO;
INFOPLIST_FILE = CollapsibleTableSectionViewController/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
Expand All @@ -362,8 +413,8 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_SWIFT3_OBJC_INFERENCE = On;
SWIFT_VERSION = 4.2;
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
SWIFT_VERSION = 5.0;
};
name = Debug;
};
Expand All @@ -373,44 +424,48 @@
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "";
DEFINES_MODULE = YES;
DEVELOPMENT_ASSET_PATHS = CollapsibleTableSectionViewController/Assets.xcassets;
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
ENABLE_ON_DEMAND_RESOURCES = NO;
INFOPLIST_FILE = CollapsibleTableSectionViewController/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = jeantimex.com.CollapsibleTableSectionViewController;
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_SWIFT3_OBJC_INFERENCE = On;
SWIFT_VERSION = 4.2;
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
SWIFT_VERSION = 5.0;
};
name = Release;
};
0A8BD6841F231B2C003D6155 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
DEVELOPMENT_TEAM = 589RNFRDJ2;
INFOPLIST_FILE = CollapsibleTableSectionViewControllerTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = jeantimex.com.CollapsibleTableSectionViewControllerTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_SWIFT3_OBJC_INFERENCE = On;
SWIFT_VERSION = 4.2;
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
SWIFT_VERSION = 5.0;
};
name = Debug;
};
0A8BD6851F231B2C003D6155 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
DEVELOPMENT_TEAM = 589RNFRDJ2;
INFOPLIST_FILE = CollapsibleTableSectionViewControllerTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = jeantimex.com.CollapsibleTableSectionViewControllerTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_SWIFT3_OBJC_INFERENCE = On;
SWIFT_VERSION = 4.2;
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
SWIFT_VERSION = 5.0;
};
name = Release;
};
Expand Down
28 changes: 12 additions & 16 deletions ...ontroller.xcodeproj/xcshareddata/xcschemes/CollapsibleTableSectionViewController.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1010"
LastUpgradeVersion = "1230"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand All @@ -26,8 +26,17 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
codeCoverageEnabled = "YES"
shouldUseLaunchSchemeArgsEnv = "YES">
shouldUseLaunchSchemeArgsEnv = "YES"
codeCoverageEnabled = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "0A8BD66B1F231B2C003D6155"
BuildableName = "CollapsibleTableSectionViewController.framework"
BlueprintName = "CollapsibleTableSectionViewController"
ReferencedContainer = "container:CollapsibleTableSectionViewController.xcodeproj">
</BuildableReference>
</MacroExpansion>
<Testables>
<TestableReference
skipped = "NO">
Expand All @@ -40,17 +49,6 @@
</BuildableReference>
</TestableReference>
</Testables>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "0A8BD66B1F231B2C003D6155"
BuildableName = "CollapsibleTableSectionViewController.framework"
BlueprintName = "CollapsibleTableSectionViewController"
ReferencedContainer = "container:CollapsibleTableSectionViewController.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
Expand All @@ -71,8 +69,6 @@
ReferencedContainer = "container:CollapsibleTableSectionViewController.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
Expand Down
6 changes: 6 additions & 0 deletions CollapsibleTableSectionViewController/Assets.xcassets/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"info" : {
"author" : "xcode",
"version" : 1
}
}
21 changes: 21 additions & 0 deletions CollapsibleTableSectionViewController/Assets.xcassets/arrow.imageset/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"images" : [
{
"filename" : "iconfinder_arrow_right2_1814086.svg",
"idiom" : "universal",
"scale" : "1x"
},
{
"idiom" : "universal",
"scale" : "2x"
},
{
"idiom" : "universal",
"scale" : "3x"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
9 changes: 9 additions & 0 deletions ...ewController/Assets.xcassets/arrow.imageset/iconfinder_arrow_right2_1814086.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading