Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template project for JDN with Selenide #1

Merged
merged 28 commits into from
Jan 23, 2024
Merged

Template project for JDN with Selenide #1

merged 28 commits into from
Jan 23, 2024

Conversation

spbqaru
Copy link
Contributor

@spbqaru spbqaru commented Dec 26, 2023

Template project for JDN with Selenide

@AlexeyGirin AlexeyGirin requested a review from pnatashap January 3, 2024 13:04
pnatashap
pnatashap requested changes Jan 5, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated
</dependency>
<dependency>
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

дубль

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удалил

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated
<suiteXmlFile>src/test/resources/testng.xml</suiteXmlFile>
</suiteXmlFiles>
<argLine>
${aspectj.args}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не нужен этот параметр

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удалил

pom.xml Outdated Show resolved Hide resolved
src/test/java/test/BaseTest.java Outdated Show resolved Hide resolved
src/test/java/test/BaseTest.java Outdated Show resolved Hide resolved
src/test/resources/testng.xml Outdated Show resolved Hide resolved
pnatashap
pnatashap requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

еще было бы хорошо иметь github action для запуска и проверки, что оно работает, чтобы не скачивать себе

pom.xml Outdated Show resolved Hide resolved
@spbqaru spbqaru requested a review from pnatashap January 9, 2024 13:13
Aleksandr_Vorobev added 2 commits January 19, 2024 00:13
@spbqaru
Copy link
Contributor Author

spbqaru commented Jan 23, 2024

еще было бы хорошо иметь github action для запуска и проверки, что оно работает, чтобы не скачивать себе

добавлены ACTIONS
https://github.com/jdi-templates/jdn-template-selenide/actions/workflows/build.yml

@AlexeyGirin AlexeyGirin merged commit e765fc1 into main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnatashap pnatashap Awaiting requested review from pnatashap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spbqaru @pnatashap @AlexeyGirin