Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaky bucket issue. #194

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix leaky bucket issue. #194

merged 1 commit into from
Jan 2, 2025

Conversation

hexiaofeng
Copy link
Collaborator

What is the purpose of the change?

Fix issue #193

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in joylive-demo project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@hexiaofeng hexiaofeng requested a review from chenzhiguo January 2, 2025 09:27
@hexiaofeng hexiaofeng linked an issue Jan 2, 2025 that may be closed by this pull request
Fix leaky bucket limiter issue. #193
Closed
@hexiaofeng hexiaofeng self-assigned this Jan 2, 2025
@hexiaofeng hexiaofeng added the bug Something isn't working label Jan 2, 2025
chenzhiguo
chenzhiguo approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@chenzhiguo chenzhiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzhiguo chenzhiguo merged commit 3166ce3 into main Jan 2, 2025
1 check passed
@hexiaofeng hexiaofeng deleted the 193-fix-leaky-bucket-limiter-issue branch January 3, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzhiguo chenzhiguo chenzhiguo approved these changes

Assignees

@hexiaofeng hexiaofeng

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix leaky bucket limiter issue.
2 participants
@hexiaofeng @chenzhiguo