Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extension condition #180

Merged

Conversation

hexiaofeng
Copy link
Collaborator

What is the purpose of the change?

Refactor extension condition

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in joylive-demo project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@hexiaofeng hexiaofeng self-assigned this Dec 19, 2024
@hexiaofeng hexiaofeng added bug Something isn't working enhancement New feature or request labels Dec 19, 2024
Copy link
Collaborator

@chenzhiguo chenzhiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzhiguo chenzhiguo merged commit 3984466 into main Dec 19, 2024
1 check passed
@hexiaofeng hexiaofeng deleted the 170-support-custom-condition-to-simplify-configuration branch December 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants