Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof of concept to serve compressed files #78

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aguaviva
Copy link

Just wanted some feedback on whether this is the right way to go.

@aguaviva aguaviva closed this Feb 18, 2022
@aguaviva aguaviva reopened this Feb 18, 2022
@aguaviva
Copy link
Author

any feedback is welcome

@aguaviva
Copy link
Author

Any updates on this?

@jczic
Copy link
Owner

jczic commented Sep 17, 2022

Hello @aguaviva and sorry for the time :)
Yes it's cool, but just :
Could you add the support (the case) of Accept-Encoding header in request before return a compressed file ?
Developer.Mozilla: Accept-Encoding
You can use self._request.GetHeader('Accept-Encoding') to get values or None.

@gitcnd
Copy link

gitcnd commented Oct 28, 2023

Supporting "Accept-Encoding" is the wrong idea.

Compression is needed to SAVE SPACE on the microcontroller, so there is NEVER any situation when non-compressed alternative content will get served to the browser. All browsers ALWAYS supports compression, even if it never said "Accept-Encoding" in the first place.

Nobody wants to store a second uncompressed copy of their files on their MCU of course !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants