Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for banner display position when status bar is hidden #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for banner display position when status bar is hidden #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Library/JCNotificationBannerPresenterIOS7Style.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ - (void) presentNotification:(JCNotificationBanner*)notification
[banner getCurrentPresentingStateAndAtomicallySetPresentingState:YES];

CGSize statusBarSize = [[UIApplication sharedApplication] statusBarFrame].size;
// if the status bar is hidden it has size 0, so pretend it's the width of the display window
if(CGSizeEqualToSize(statusBarSize, CGSizeZero)) {
statusBarSize = CGSizeMake(window.bounds.size.width, statusBarSize.height);
}
// Make the banner fill the width of the screen, minus any requested margins,
// up to self.bannerMaxWidth.
CGSize bannerSize = CGSizeMake(MIN(self.bannerMaxWidth, originalControllerView.bounds.size.width), self.bannerHeight);
Expand Down
4 changes: 4 additions & 0 deletions Library/JCNotificationBannerPresenterIOSStyle.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ - (void) presentNotification:(JCNotificationBanner *)notification
[banner getCurrentPresentingStateAndAtomicallySetPresentingState:YES];

CGSize statusBarSize = [[UIApplication sharedApplication] statusBarFrame].size;
// if the status bar is hidden it has size 0, so pretend it's the width of the display window
if(CGSizeEqualToSize(statusBarSize, CGSizeZero)) {
statusBarSize = CGSizeMake(window.bounds.size.width, statusBarSize.height);
}
CGFloat width = 320.0;
CGFloat height = 60.0;
CGFloat x = (MAX(statusBarSize.width, statusBarSize.height) - width) / 2.0;
Expand Down
4 changes: 4 additions & 0 deletions Library/JCNotificationBannerPresenterSmokeStyle.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ - (void) presentNotification:(JCNotificationBanner*)notification
[banner getCurrentPresentingStateAndAtomicallySetPresentingState:YES];

CGSize statusBarSize = [[UIApplication sharedApplication] statusBarFrame].size;
// if the status bar is hidden it has size 0, so pretend it's the width of the display window
if(CGSizeEqualToSize(statusBarSize, CGSizeZero)) {
statusBarSize = CGSizeMake(window.bounds.size.width, statusBarSize.height);
}
// Make the banner fill the width of the screen, minus any requested margins,
// up to self.bannerMaxWidth.
CGSize bannerSize = CGSizeMake(MIN(self.bannerMaxWidth, originalControllerView.bounds.size.width - self.minimumHorizontalMargin * 2.0), self.bannerHeight);
Expand Down