fix: problems with latest Go1.23 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, could we maybe cut a release once this issue gets fixed? |
jcchavezs
reviewed
Nov 12, 2024
Co-authored-by: José Carlos Chávez <[email protected]>
jcchavezs
approved these changes
Nov 12, 2024
|
Done. |
|
Thank you @jcchavezs! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://go-review.googlesource.com/c/go/+/560137/4/src/io/fs/sub.go#36, the returned error has been changed, therefore we are not able to match it anymore. We have not been able to spot the issue until users started upgrading Coraza connectors, therefore I'm adding tests on both this PR and Coraza main PR.
Issue described: corazawaf/coraza#1208
Coraza PR that adds a test: corazawaf/coraza#1211