Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new constructor to support Redis username #18

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

alordtas
Copy link
Contributor

We need to provide the redis username when instantiating the adapter.
I added a new constructor which takes the username as an additional parameter, no change to the existing behaviour

@casbin-bot casbin-bot requested a review from imp2002 March 27, 2024 16:12
@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@casbin-bot casbin-bot requested a review from tangyang9464 March 27, 2024 16:12
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 60.92%. Comparing base (b487cc0) to head (353daba).
Report is 1 commits behind head on master.

Files Patch % Lines
src/main/java/org/casbin/adapter/RedisAdapter.java 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   63.01%   60.92%   -2.09%     
==========================================
  Files           3        3              
  Lines         146      151       +5     
  Branches       30       31       +1     
==========================================
  Hits           92       92              
- Misses         36       41       +5     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 27, 2024

@alordtas can you also update the README about this usage?

@hsluoyz hsluoyz closed this Mar 27, 2024
@hsluoyz hsluoyz reopened this Mar 27, 2024
@hsluoyz hsluoyz changed the title Added option to provide specific redis username when initialising the adapter feat: add new constructor to support Redis username Mar 27, 2024
@hsluoyz hsluoyz merged commit 0f92b7b into jcasbin:master Mar 27, 2024
2 of 6 checks passed
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants