Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit tests for Casbin enforcer #12

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

ailiujiarui
Copy link
Contributor

@ailiujiarui ailiujiarui commented Mar 20, 2024

fix: #9

feat: add test class for casbin issue

Reproduce the code logic in the discussion at casbin/casbin#1375 (comment) using Java, write a test for this issue, then test it with the examples from the casbin official docs, and see if the output is the same as the official website.

@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@ailiujiarui ailiujiarui changed the title The test for the issue feat: add test class for casbin issue Mar 20, 2024
src/test/java/org/casbin/MenuTest.java Outdated Show resolved Hide resolved
src/test/java/org/casbin/MenuTest.java Outdated Show resolved Hide resolved
@hsluoyz
Copy link
Member

hsluoyz commented Mar 20, 2024

@ailiujiarui fix CI:

image

@ailiujiarui ailiujiarui force-pushed the Menutest branch 2 times, most recently from afd4504 to bdb2356 Compare March 21, 2024 08:03
@hsluoyz hsluoyz closed this Mar 24, 2024
@hsluoyz hsluoyz reopened this Mar 24, 2024
@hsluoyz hsluoyz changed the title feat: add test class for casbin issue feat: add unit tests for Casbin enforcer Mar 24, 2024
@hsluoyz hsluoyz merged commit f60130c into jcasbin:master Mar 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add test cases from the docs and discussion
3 participants