Sepolia deploy #15
Merged
Sepolia deploy #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipviz
force-pushed
the
deployment/sepolia
branch
from
a956570 to
d5d7a15
Compare
|
Working now |
|
|
||
| // Have to use its own address as the `_oldHandle`. | ||
| // TODO: UPDATE THIS EACH TIME YOU DEPLOY. | ||
| address willBeDeployedAt = _addressFrom(0xfAb4c9E48EB050E8f51555Ef949a7ef1b8fb263B, 0); |
There was a problem hiding this comment.
what's this address? It should be the deployer, so msg.sender should be good (as for the nonce, use vm.getNonce(deployer address)?)
There was a problem hiding this comment.
I used this suggestion like so:
address willBeDeployedAt = _addressFrom(msg.sender, vm.getNonce(msg.sender));And it didn't work when I tried it locally on an anvil fork of sepolia. I also tried using nonce + 1 – also did not work.
If you can get it working, please do! Otherwise I think it's fine to just update the address on new deployments.
mejango
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a zero address for
_oldHandlein the Sepolia deploy script. Is that fine @drgorillamd ?