Dev blocked projects and block Metakeys copy-cat #4067
Merged
+81
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
johnnyd-eth
force-pushed
the
delist-copy-project
branch
from
f52a82a to
247eee6
Compare
johnnyd-eth
commented
Sep 14, 2023
| @@ -68,7 +69,13 @@ export function useDBProjectsInfiniteQuery( | |||
| pageSize, | |||
| })}`, | |||
| ) | |||
| .then(res => (res.data ? res.data.map(parseDBProject) : [])) | |||
| .then(res => | |||
There was a problem hiding this comment.
Adds filters to "all" (same as the "new" query) and "trending" projects queries
johnnyd-eth
force-pushed
the
delist-copy-project
branch
from
247eee6 to
27dcd92
Compare
src/constants/blocklist.ts
Outdated
| @@ -0,0 +1,4 @@ | |||
| // List of delisted projects | |||
| export const BLOCKED_PROJECT_IDS = [ | |||
| '564', //copycat of 563 | |||
There was a problem hiding this comment.
we'll want these to be project ids (e.g. "2-564"), not projectIds (otherwise this would block a v1 project 564). we also want it to be specific to mainnet
There was a problem hiding this comment.
or, we could copy the pattern used for archived projects (storing V2ArchivedProjectIdsByNetwork that are all pv == 2), but we need to add the pv == 2 statement in the filter. archived project lists are network-specific
cleanup project filtering on db projects queries
peripheralist
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects listed in
BLOCKED_PROJECT_IDS: