[DO NOT MERGE] Compatibility for subgraph nft collections #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
peripheralist
commented
Sep 5, 2023
| client, | ||
| variables: { | ||
| where: { | ||
| ...(dataSourceAddress ? { address: dataSourceAddress } : {}), | ||
| ...(dataSourceAddress |
There was a problem hiding this comment.
we now query by nft.collection.address instead of nft.address
peripheralist
force-pushed
the
peri/nft-collections-ui-compatibility
branch
from
13e5465 to
da152fd
Compare
johnnyd-eth
reviewed
Sep 12, 2023
| @@ -1,16 +1,16 @@ | |||
| import Loading from 'components/Loading' | |||
| import { Jb721DelegateTokensQuery } from 'generated/graphql' | |||
| import { NfTsQuery } from 'generated/graphql' | |||
There was a problem hiding this comment.
ohh awk. looks like it's just the codegen output making NFTs -> NfTs query. just gonna leave it
johnnyd-eth
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subgraph is still indexing, can be merged once complete. Plz approve in the meantime
Just a change to the graphql structure for querying JB721DelegateTokens—now simply called NFTs for simplicity. No functional changes
this will fail until the CI url is updated